Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aptos]: Add support for fungible assets #4206

Merged
merged 5 commits into from
Jan 10, 2025
Merged

[Aptos]: Add support for fungible assets #4206

merged 5 commits into from
Jan 10, 2025

Conversation

gupnik
Copy link
Collaborator

@gupnik gupnik commented Jan 10, 2025

Description

This PR adds the ability to transfer fungible assets on Aptos.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Binary size comparison

➡️ aarch64-apple-ios:

- 12.53 MB
+ 12.53 MB 	 +7 KB

➡️ aarch64-apple-ios-sim:

- 12.53 MB
+ 12.54 MB 	 +6 KB

➡️ aarch64-linux-android:

- 16.18 MB
+ 16.19 MB 	 +10 KB

➡️ armv7-linux-androideabi:

- 13.79 MB
+ 13.80 MB 	 +7 KB

➡️ wasm32-unknown-emscripten:

- 11.47 MB
+ 11.48 MB 	 +7 KB

satoshiotomakan
satoshiotomakan requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gupnik, thanks for adding Fungible Asset support

rust/chains/tw_aptos/src/aptos_move_packages.rs Outdated Show resolved Hide resolved
rust/chains/tw_aptos/src/transaction_builder.rs Outdated Show resolved Hide resolved
src/proto/Aptos.proto Outdated Show resolved Hide resolved
tests/chains/Aptos/TWAnySignerTests.cpp Outdated Show resolved Hide resolved
@gupnik
Copy link
Collaborator Author

gupnik commented Jan 10, 2025

@satoshiotomakan Thanks for the review. I have addressed your comments. Could you please take another look?

satoshiotomakan
satoshiotomakan approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshiotomakan satoshiotomakan merged commit 6bae053 into master Jan 10, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/aptos-fungible-asset branch January 10, 2025 11:21
@trustwallet trustwallet deleted a comment from Ruyeduardo Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshiotomakan satoshiotomakan satoshiotomakan approved these changes

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gupnik @satoshiotomakan