build: Fix version in docker binaries

trustyou · Jun 18, 2024 · 8ef3099 · 8ef3099
1 parent 477ec62
commit 8ef3099
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -1,7 +1,9 @@
 FROM golang:1.22.4 AS builder
 
+ARG VERSION
+
 COPY . .
-RUN make kured-alert-silencer
+RUN VERSION=${VERSION} make kured-alert-silencer
 
 FROM alpine:3.20.0
 

diff --git a/Makefile b/Makefile
@@ -28,12 +28,14 @@ kured-alert-silencer:
 .PHONY: image
 image:
 	$(SUDO) docker buildx build $(DOCKER_EXTRA_ARGS) \
+		--build-arg VERSION=$(VERSION) \
 		--load -t ghcr.io/$(DH_ORG)/kured-alert-silencer:$(VERSION) .
 
 .PHONY: push-images
 push-images: DOCKER_EXTRA_ARGS ?= --platform linux/amd64,linux/arm64
 push-images:
 	$(SUDO) docker buildx build $(DOCKER_EXTRA_ARGS) \
+		--build-arg VERSION=$(VERSION) \
 		--push -t ghcr.io/$(DH_ORG)/kured-alert-silencer:$(VERSION) .
 
 .PHONY: manifest