Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace q-io with fs-extra #82

Closed
wants to merge 1 commit into from
Closed

Replace q-io with fs-extra #82

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Mar 6, 2020

@tschaub there's one instance left in this file, feel free to push a patch to this branch and then we can remove q-io :)

@XhmikosR XhmikosR force-pushed the rm-q-io branch 2 times, most recently from dbe7f9e to 12710e8 Compare April 14, 2020 07:31
@XhmikosR XhmikosR changed the title Remove q-io Replace q-io with fs-extra Apr 14, 2020
@XhmikosR XhmikosR marked this pull request as ready for review April 14, 2020 07:32
@XhmikosR
Copy link
Contributor Author

I'm not sure if these are covered by the tests, but everything seems to work fine on new Node.js @tschaub. Please confirm just to be safe.

@XhmikosR XhmikosR requested a review from tschaub April 14, 2020 07:33
@XhmikosR
Copy link
Contributor Author

@tschaub please check my other notifications on this repo too 🙂

Also, go ahead and merge anything you review, because if CI doesn't pass I cannot merge myself. Unless we merge #84 first.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 15, 2020

Oh, and if you could enable the repo option for the branches to be up to date and delete HEAD branches, that would be save some time.

EDIT: BTW this patch is moot if we ever get to implement #76

@tschaub
Copy link
Owner

tschaub commented Apr 16, 2020

Hello @XhmikosR. I've initiated a transfer of this repository to you. I'm not actively using Grunt, so don't want to block maintenance or updates to this project. If you accept the transfer and let me know your npm username, I can add you as a maintainer of the package.

@XhmikosR
Copy link
Contributor Author

Thanks for the offer, but I can't maintain the package either. It's just that I decided to submit a few last patches. Maybe just archive the project?

@tschaub tschaub mentioned this pull request Apr 16, 2020
@tschaub tschaub closed this in #88 Apr 16, 2020
@XhmikosR XhmikosR deleted the rm-q-io branch April 16, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants