-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeJS v12 compatibility #17
Conversation
The build is failing, because Will be resolved after release, by bumping the dependency version in |
Node is moving to NAPI so everyone and everything is moving to -napi to avoid compatibility issues. This is required for NodeJS v12 compatibility.
@types/ref-array-napi/index.d.ts
Outdated
@@ -0,0 +1,65 @@ | |||
// Type definitions for ref-array-napi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea :) but, I have a doubt when the npm package will be released. Theses files won't be packaged. It means theses types won't be available when a developer install our package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to fix it, you have to move this files in src/@types and import it in index.ts? Why do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it out right now.
Ohhhh, I didn't see you forced push and I've pushed again. Can you please make a force push again from your local branch without pulling the changes from remote? This will fix the issue. |
BTW, moving |
Ok, I've resolved the git issue and moved |
Nice :). I'll merge your PR |
Release is on going :) |
Released :) |
ref
package does not work with NodeJS v12 and will never be: sourceThis PR updates
.nvmrc
to NodeJS 12 and usesref-napi
libs family instead ofref
to resolve the issue.Two type definitions are added to the project, which will be removed after this and this PR's will be merged and released.
This change is tested with NodeJS 12.13.0, MacOS 10.13.6 and my Canon 80D. Everything works as before.
The example folder is a broken at the moment, because it attempts to install an old ts-gphoto2-driver version and it fails, because of
ref
module can not be compiled under NodeJS v12. I suggest to release a2.4.0
version of this lib and bump the dependency version inexamples/package.json
after.