-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for valid input in ARG likelihood #2114
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2114 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 19 19
Lines 10852 10856 +4
Branches 2222 2224 +2
=======================================
+ Hits 9907 9911 +4
Misses 516 516
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can you rebase once #2116 is merged please @JereKoskela? |
f01f134
to
c25eb93
Compare
Done @jeromekelleher |
Needs a test or two, can be something quite simple. Probably easiest to hand construct a few tree sequences that we'd like to reject. |
c25eb93
to
cc6025a
Compare
I've added a test to cover the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This outputs a readable error message when ARGs are requested for trees which aren't binary.
I haven't put in a check for unary nodes because those will legitimately appear on trees due to RE nodes.
Closes #2107