Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tests/data folder #2228

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

GertjanBisschop
Copy link
Member

remove tests/data folder as mentioned in #1952 .

@GertjanBisschop
Copy link
Member Author

Aha, the contents of this folder are still used in the following places. Have misunderstood the issue.

test_demography.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/minimal-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/minimal-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/single-locus-example.trees")
test_simulate_from.py:        from_ts = tskit.load("tests/data/SLiM/single-locus-example.trees")
test_species_tree_parsing.py:        tree_file = "tests/data/species_trees/101g_nucl_conc_unconst.combined.nwk.tre"
test_species_tree_parsing.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:
test_species_tree_parsing.py:        with open("tests/data/species_trees/91genes_species_rev.tre") as f:

So is it only tests/data/hdf5-formats and tests/data/simplify-bugs that should be removed?

@jeromekelleher
Copy link
Member

Ah yes, good spot. Let's remove just unused stuff

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2228 (9c1e5b6) into main (13bf955) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          20       20           
  Lines       11334    11334           
  Branches     2302     2302           
=======================================
  Hits        10373    10373           
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.52% <ø> (ø)
python 98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bf955...9c1e5b6. Read the comment docs.

@mergify mergify bot merged commit 4c80801 into tskit-dev:main Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants