Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ll_representation argument #2231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GertjanBisschop
Copy link
Member

Removed argument of DemographicEvent.get_ll_representation(). Solves #1037 as this is no longer used by stdpopsim.
The TestLowLevelRepresentation test suite is marked as containing tests that were only needed to ensure compatibility with stdpopsim. I couldn't see any calls containing the optional argument. Are there any other tests I can remove @jeromekelleher?

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2231 (7db7dce) into main (11615e0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2231   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          20       20           
  Lines       11334    11334           
  Branches     2302     2302           
=======================================
  Hits        10373    10373           
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.52% <100.00%> (ø)
python 98.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
msprime/demography.py 99.33% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11615e0...7db7dce. Read the comment docs.

@jeromekelleher
Copy link
Member

I think it should be fine... I guess someone with an old stdpopsim who keeps their msprime up to date will hit problems?

Stdpopsim 0.2.0 came out over a year ago, but maybe the potential headaches aren't actually worth the small cleanup here.

https://github.com/popsim-consortium/stdpopsim/releases/tag/0.2.0

Let's keep this PR open and merge it in another year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants