Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress subnormal warning #988

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

benjeffery
Copy link
Member

Fixes #957

I think this is safe as the subnormals are tiny on a 64bit float.

@hyanwong I couldn't recreate the warning locally, maybe because of architecture differences - so can you confirm this suppresses the warning?

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (1c7928b) to head (61619b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   93.16%   93.17%           
=======================================
  Files          18       18           
  Lines        6368     6370    +2     
  Branches     1086     1086           
=======================================
+ Hits         5933     5935    +2     
  Misses        296      296           
  Partials      139      139           
Flag Coverage Δ
C 93.17% <100.00%> (+<0.01%) ⬆️
python 95.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 0a83c7b into tskit-dev:main Jan 9, 2025
14 checks passed
@hyanwong
Copy link
Member

hyanwong commented Jan 9, 2025

Looks like that fixed it. Thanks @benjeffery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: The value of the smallest subnormal for <class 'numpy.float64'> type is zero.
3 participants