Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when using defaults that aren't explict and not metadata #992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benjeffery
Copy link
Member

Fixes #766

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (e3b2155) to head (8235f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   93.17%   93.18%           
=======================================
  Files          18       18           
  Lines        6374     6379    +5     
  Branches     1088     1088           
=======================================
+ Hits         5939     5944    +5     
  Misses        296      296           
  Partials      139      139           
Flag Coverage Δ
C 93.18% <100.00%> (+<0.01%) ⬆️
python 95.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sgkit: Warn when default content for a missing dataset array is used.
1 participant