CODE: normalise #130
Merged
CODE: normalise #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 330 341 +11
Branches 46 48 +2
=========================================
+ Hits 330 341 +11 ☔ View full report in Codecov by Sentry. |
|
Edit: Verification against ARG-Needle simulation will be added later. |
daikitag
force-pushed
the
normalize
branch
2 times, most recently
from
fa6eeff to
70d6cd9
Compare
jeromekelleher
approved these changes
Feb 6, 2024
docs/quick-start.md
Outdated
| ## Normalise Phenotype | ||
|
|
||
| The simulated phenotypes can be scaled by using the {func}`normalise_phenotypes` function. The function | ||
| will first normalise the phenotype by subtrating the mean of the input phenotype from each |
There was a problem hiding this comment.
I just fixed it now, and thank you for spotting this
Add `normalise_phenotype` function in tstrait.
jeromekelleher
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
normalise_phenotypefunction in tstrait. Statistical tests are also added toverification.pyto validate the normalized simulated tstrait phenotype against phenotypes that are generated by using the simulation framework which is used in the ARG-Needle paper (https://zenodo.org/records/7745746).