-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz Authoring Form #3
Open
jonhartm
wants to merge
63
commits into
tsugitools:master
Choose a base branch
from
jonhartm:authoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistakenly passed "context" instead of "answer_context" when loading a quiz, and forgot to increment the question number when adding a blank field on the bottom
facilitates adding answers as a result of JS events
One to go back to the index (if a quiz is long, this would be better than scrolling to the cancel button at the bottomt) One to go to old_configure.php, which still allows for direct input of gift quizzes
After the user presses a button to add the next answer, I want the button they pressed to turn from "+" to "-" and change in function to remove that answer rather than add another
Just count the number of children in the quiz content div before adding each question
</form> was far too early so the "save" button didn't register when pressed
So I don't have to calculate it later
name will always be "answer1_qustionX". Makes it a little easier for the parser.
Added helper file with functions to parse the POST from the authoring form, and a few tests to confirm it works as expected
"save" now just stores the quiz in the database, "save and return" saves the quiz and returns to the index
just reviewing the code and making sure I didn't forget something obvious
I'm going to use this once or twice more, so I'm making a new rule rather than type the margins multiple times
Only look at the checkboxes that are within a possible answer div, since the "Use HTML" checkbox was being picked up.
wrapped the buttons in a 33% width div, which is now a trigger for validating the quiz
Might be overkill. We'll see.
SQL query to see if this particular Link object has at least one result from a student, and if so display a warning message that must be dismissed before the quiz can be edited
there's always the option to remove an answer, and the last answer always has an add option.
The "-" button is supressed in the template when it is the first answer in a question. Also a CSS change to standardize the height of the answer div to keep it from jumping up and down when the "+" appears/disappears on the first answer.
The state of the checkbox isn't saved in .html(), so we store it manually before renaming the answers, then re-apply the checks after each renaming
When the Authorign form got particuarly long, the frame didn't shrink back when the user returned to the index, which was a little annoying.
Added a dropdown next to the delete button that allows the user to change the type of question.
Added a dropdown next to the delete button that allows the user to change the type of question.
Commented out the debug button, and removed the un-needed div from the save buttons and it's associated CSS rule.
Not pretty, but it works. change_question_type is now called with the div, which is parsed to get the question number. When the questions are renumbered, the html that makes this call is updated as well.
Finished javascript validation, frame resizing, warning if the quiz has already been taken, and made some changes to the UI . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promised bare-bones quiz authoring tool.
Still on my TODO list:
Bigger things:
Smaller things:
If there's anything else you might think of to include, just let me know and I'll see what I can do.