fix: improve feed states notification

.golangci.yml

@@ -103,6 +103,8 @@ linters-settings:
         # Whether to skip (*x).method() calls where x is a pointer receiver.
         # Default: true
         skipRecvDeref: false
+    disabled-checks:
+      - ifElseChain # too much false positives
 
   gomnd:
     # List of function patterns to exclude from analysis.

app/sephirah/internal/biz/bizangela/feed.go

@@ -28,10 +28,6 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
 	return libmq.NewTopic[modelyesod.PullFeed](
 		"PullFeed",
 		func(ctx context.Context, p *modelyesod.PullFeed) error {
-			if !a.supv.CheckFeedSource(p.Source) {
-				return nil
-			}
-
 			// Prepare for updating feed pull status
 			fc := new(modelyesod.FeedConfig)
 			fc.ID = p.InternalID
@@ -42,16 +38,24 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
 				_ = a.repo.UpdateFeedPullStatus(ctx, fc)
 				if p.SystemNotify != nil {
 					un := *p.SystemNotify
-					if fc.LatestPullStatus == modelyesod.FeedConfigPullStatusSuccess {
+					if fc.LatestPullMessage == "" {
 						un.Notification.Level = modelnetzach.SystemNotificationLevelInfo
+					} else if fc.LatestPullStatus == modelyesod.FeedConfigPullStatusSuccess {
+						un.Notification.Level = modelnetzach.SystemNotificationLevelWarning
 					} else {
 						un.Notification.Level = modelnetzach.SystemNotificationLevelError
-						un.Notification.Content = fc.LatestPullMessage
 					}
+					un.Notification.Content = fc.LatestPullMessage
 					_ = systemNotify.PublishFallsLocalCall(ctx, un)
 				}
 			}()
 
+			// Check porter availability
+			if !a.supv.CheckFeedSource(p.Source) {
+				fc.LatestPullMessage = fmt.Sprintf("Pull %s feature not activate", p.Source)
+				return nil
+			}
+
 			// Pull feed and upsert
 			resp, err := a.porter.PullFeed(
 				a.supv.CallFeedSource(ctx, p.Source),
@@ -99,19 +103,25 @@ func NewPullFeedTopic( //nolint:gocognit // TODO
 			}
 			fc.LatestPullStatus = modelyesod.FeedConfigPullStatusSuccess
 
-			// Send to notify router
+			// Queue ParseFeedItemDigest and NotifyRouter
 			newItems := make([]*modelfeed.Item, 0, len(newItemGUIDs))
 			for _, item := range feed.Items {
 				if slices.Contains(newItemGUIDs, item.GUID) {
 					newItems = append(newItems, item)
-					_ = parse.Publish(ctx, modelangela.ParseFeedItemDigest{ID: item.ID})
+					err = parse.Publish(ctx, modelangela.ParseFeedItemDigest{ID: item.ID})
 				}
 			}
+			if err != nil {
+				fc.LatestPullMessage = fmt.Sprintf("Queue ParseFeedItemDigest failed: %s", err.Error())
+			}
 			if len(newItems) > 0 {
-				_ = notify.Publish(ctx, modelangela.NotifyRouter{
+				err = notify.Publish(ctx, modelangela.NotifyRouter{
 					FeedID:   feed.ID,
 					Messages: newItems,
 				})
+				if err != nil {
+					fc.LatestPullMessage = fmt.Sprintf("Queue NotifyRouter failed: %s", err.Error())
+				}
 			}
 			return nil
 		},

app/sephirah/internal/biz/bizyesod/yesod.go

@@ -112,7 +112,7 @@ func (y *Yesod) PullFeeds(ctx context.Context) error {
 				owner.ID,
 				modelnetzach.SystemNotificationLevelOngoing,
 				fmt.Sprintf("Scheduled Server Task: Update Feed %s", c.Name),
-				"",
+				"Queued",
 			)
 			un.Notification.ID, err = y.searcher.NewID(ctx)
 			if err != nil {

app/sephirah/internal/data/angela.go

@@ -2,6 +2,7 @@ package data
 
 import (
 	"context"
+	"fmt"
 	"time"
 
 	"github.com/tuihub/librarian/app/sephirah/internal/biz/bizangela"
@@ -318,6 +319,10 @@ func (a *angelaRepo) UpsertSystemNotification(
 	userID model.InternalID,
 	notification *modelnetzach.SystemNotification,
 ) error {
+	n, err := a.data.db.SystemNotification.Get(ctx, notification.ID)
+	if err == nil && n != nil && len(n.Content) > 0 {
+		notification.Content = fmt.Sprintf("%s\n%s", n.Content, notification.Content)
+	}
 	q := a.data.db.SystemNotification.Create().
 		SetID(notification.ID).
 		SetType(converter.ToEntSystemNotificationType(notification.Type)).

internal/lib/libcache/key.go

@@ -74,7 +74,7 @@ func (k *Key[T]) GetWithFallBack(ctx context.Context, fallBackFunc fallBackFunc[
 	if err == nil {
 		return res, nil
 	}
-	if fallBackFunc != nil { //nolint:gocritic // no need
+	if fallBackFunc != nil {
 		res, err = fallBackFunc(ctx)
 		if err != nil {
 			return nil, err

internal/lib/libcache/map.go

@@ -83,7 +83,7 @@ func (m *Map[K, V]) GetWithFallBack(ctx context.Context, key K,
 	if err == nil {
 		return res, nil
 	}
-	if fallBackFunc != nil { //nolint:gocritic // no need
+	if fallBackFunc != nil {
 		res, err = fallBackFunc(ctx, key)
 		if err != nil {
 			return nil, err

internal/lib/libmq/mq.go

@@ -152,10 +152,10 @@ func poisonedTopicName(topic string) string {
 
 func retryMiddleware() func(h message.HandlerFunc) message.HandlerFunc {
 	return middleware.Retry{
-		MaxRetries:          5, //nolint:gomnd //TODO
+		MaxRetries:          3, //nolint:gomnd //TODO
 		InitialInterval:     time.Second,
 		MaxInterval:         time.Minute,
-		Multiplier:          2, //nolint:gomnd //TODO
+		Multiplier:          4, //nolint:gomnd //TODO
 		MaxElapsedTime:      0,
 		RandomizationFactor: 0.2, //nolint:gomnd //TODO
 		OnRetryHook:         nil,