fix: update NotifyTarget FeedConfig

tuihub · Jul 11, 2024 · 76b16ac · 76b16ac
1 parent f6895a9
commit 76b16ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/proto/librarian/sephirah/v1/netzach.proto b/proto/librarian/sephirah/v1/netzach.proto
@@ -4,6 +4,7 @@ package librarian.sephirah.v1;
 
 import "google/protobuf/timestamp.proto";
 import "librarian/v1/common.proto";
+import "librarian/v1/wellknown.proto";
 
 option csharp_namespace = "TuiHub.Protos.Librarian.Sephirah.V1";
 option go_package = "github.com/tuihub/protos/pkg/librarian/sephirah/v1;v1";
@@ -59,9 +60,8 @@ message NotifyTarget {
   string name = 2;
   string description = 3;
   // WellKnownNotifyDestination
-  string destination = 4;
+  librarian.v1.FeatureRequest destination = 4;
   NotifyTargetStatus status = 5;
-  string token = 6;
 }
 
 message NotifyFlow {
@@ -83,7 +83,6 @@ message NotifyFlowTarget {
   NotifyFilter filter = 1;
   // must be NotifyTargetID
   librarian.v1.InternalID target_id = 2;
-  string channel_id = 3;
 }
 
 message NotifyFilter {

diff --git a/proto/librarian/sephirah/v1/yesod.proto b/proto/librarian/sephirah/v1/yesod.proto
@@ -179,11 +179,11 @@ message ListFeedItemsInCollectionResponse {
 message FeedConfig {
   librarian.v1.InternalID id = 1;
   string name = 2;
-  string feed_url = 3;
-  // Not used when source is FEED_CONFIG_SOURCE_COMMON
-  librarian.v1.InternalID author_account = 4;
+  string description = 3;
   // WellKnownFeedSource
-  string source = 5;
+  librarian.v1.FeatureRequest source = 4;
+  // `FeedActionSet.id`
+  repeated librarian.v1.InternalID action_sets = 5;
   FeedConfigStatus status = 6;
   google.protobuf.Duration pull_interval = 7;
   string category = 8;
@@ -195,8 +195,6 @@ message FeedConfig {
   optional FeedConfigPullStatus latest_pull_status = 11;
   // response only
   optional string latest_pull_message = 12;
-  // `FeedActionSet.id`
-  repeated librarian.v1.InternalID action_sets = 13;
 }
 
 enum FeedConfigStatus {