refactor: align ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES with the Xcode …

…default (#881) * fix: aline always_embed_swift_standard_libiraries with the xcode default * delete always_embed_swift_standard_libraries from test targetSettings watchOSApplication * remove no longer used method * fix build error
tuist · Nov 20, 2024 · 5e09f61 · 5e09f61
1 parent 85265f3
commit 5e09f61
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/Sources/XcodeProj/Utils/BuildSettingsProvider.swift b/Sources/XcodeProj/Utils/BuildSettingsProvider.swift
@@ -72,10 +72,6 @@ public class BuildSettingsProvider {
             buildSettings.merge(targetSwiftSettings(product: product), uniquingKeysWith: { $1 })
         }
 
-        if let platform, let product, let swift, swift == true {
-            buildSettings.merge(targetSwiftSettings(platform: platform, product: product), uniquingKeysWith: { $1 })
-        }
-
         return buildSettings
     }
 
@@ -370,17 +366,6 @@ public class BuildSettingsProvider {
             return [:]
         }
     }
-
-    private static func targetSwiftSettings(platform: Platform, product: Product) -> BuildSettings {
-        switch (platform, product) {
-        case (.watchOS, .application):
-            return [
-                "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES": "YES",
-            ]
-        default:
-            return [:]
-        }
-    }
 }
 
 // Overloading `~=` enables customizing switch statement pattern matching

diff --git a/Tests/XcodeProjTests/Utils/BuildSettingsProviderTests.swift b/Tests/XcodeProjTests/Utils/BuildSettingsProviderTests.swift
@@ -135,7 +135,6 @@ class BuildSettingProviderTests: XCTestCase {
 
         // Then
         assertEqualSettings(results, [
-            "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES": "YES",
             "ASSETCATALOG_COMPILER_APPICON_NAME": "AppIcon",
             "ENABLE_PREVIEWS": "YES",
             "LD_RUNPATH_SEARCH_PATHS": ["$(inherited)", "@executable_path/Frameworks"],