Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that file references are fixed for filesystem synchronized root groups #897

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryansum
Copy link

@bryansum bryansum commented Jan 16, 2025

Short description 📝

Noticed that when building projects with the new filesystem synchronized root groups that I wasn't seeing references fixed correctly. This seems like an oversight to #827, which had tests for decoding / encoding and for equality testing but none for this in particular.

Solution 📦

This adds an additional check to ReferenceGenerator for any filesystem synchronized root groups starting from the main group, or recursively any children.

Implementation 👩‍💻👨‍💻

  • Implemented a change to ReferenceGenerator fixing any filesystem synchronized root group object references
  • Added a new test to ReferenceGeneratorTests to ensure that this is working correctly.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @bryansum

@kwridan
Copy link
Collaborator

kwridan commented Jan 21, 2025

@all-contributors add @bryansum for code

Copy link
Contributor

@kwridan

I've put up a pull request to add @bryansum! 🎉

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Looks good 🙂

Once the lint checks are resolved, we can merge this ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants