fix: add missing BuildSettingsProvider for visionOS

[alexanderwe]

Short description 📝

Tuist introduced XcodeGraph at version 0.19.4 with this PR tuist/tuist#7083. This in fact caused this PR to take effect tuist/XcodeGraph#79. This then ultimately caused this codepath https://github.com/tuist/tuist/blob/main/Sources/TuistGenerator/Settings/DefaultSettingsProvider.swift#L115 to not include visionOS related default settings.

Solution 📦

I added the mapping of visionOS to the BuildSettingsProvider in order to also correctly set the settings for visionOS.

Implementation 👩‍💻👨‍💻

• Add visionOS mappings to BuildSettingsProvider
• Update BuildSettingProviderTests to test the newly added mappings

Questions

• @fortmarek / @pepicrft I was not quite sure if we should also set CODE_SIGN_IDENTITY on the visionOS platform in order to be aligned with the iOS one - what do you think ?
• Please let me know if the explanation is good enough or if I missed something or have invalid reasoning.

[kwridan]

Thanks @alexanderwe

[pepicrft]

@fortmarek / @pepicrft I was not quite sure if we should also set CODE_SIGN_IDENTITY on the visionOS platform in order to be aligned with the iOS one - what do you think ?

I think that makes sense. Thoughts @fortmarek ?

[fortmarek]

I think that makes sense. Thoughts @fortmarek ?

I'm aligned with that as well 👍

[pepicrft]

In that case let's propagate your changes as suggested by @kwridan and we can then merge the PR. Thanks a lot @alexanderwe for this one 🚀

[alexanderwe]

@kwridan @pepicrft @fortmarek
Thanks a lot for your reviews !

I have rechecked the cases and added visionOS where needed. In addition I have now also added unit tests for these new cases. While doing that I also saw that the BuildSettingProviderTests was also missing tests for watchOS. I have added these tests as well now - if you think these should rather be in another PR to keep this one more atomic just let me know.

[fortmarek]

Thanks! Looks good 🙂

[fortmarek]

While doing that I also saw that the BuildSettingProviderTests was also missing tests for watchOS. I have added these tests as well now - if you think these should rather be in another PR to keep this one more atomic just let me know.

These minor fly-by changes are fine – thanks for improving that!

[alexanderwe]

@fortmarek Thanks for merging !