update gurobi and python version #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slivingston
reviewed
Oct 3, 2024
| ``` | ||
| Navigate to the repo and run to install the FLORAS and all required dependencies: | ||
| Navigate to the repo to install floras and all required dependencies: |
There was a problem hiding this comment.
The use of upper vs. lower case "FLORAS" and "floras" is somewhat confusing. Tulip is an example of an original name that was notoriously difficult to write: "TuLiP", followed over the years by several variations on this ("tulip", "Tulip", tulip). I recommend to decide on a style now and try to be consistent in the documentation.
There was a problem hiding this comment.
Agreed, floras seems easiest.
slivingston
reviewed
Oct 3, 2024
slivingston
reviewed
Oct 3, 2024
|
I made several comments about the documentation; else, this is good to merge. Consider using the "Squash and merge" option because many of the commits of this pull request are not worth saving because they are from the trial-and-error approach of debugging errors in CI. |
Co-authored-by: Scott C. Livingston <[email protected]>
Co-authored-by: Scott C. Livingston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.