-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tests, update installation instructions, add case study #8
Conversation
jgraeb
commented
Jan 7, 2025
- updated the tests to run in conda environment
- updated installation instructions in readme and installation page on website
- added package delivery case study
Co-authored-by: Scott C. Livingston <[email protected]>
Co-authored-by: Scott C. Livingston <[email protected]>
Add casestudy
Casestudy
add more info
* add test coverage workflow, upload to codecov, add codecov badge
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
The MacOS test with conda (python 3.10) succeeded for the second to last commit, but then I just removed the badge svg file and the htmlcov directory and it is broken again (these changes shouldn't have affected the workflow). @slivingston do you have any ideas why this is so unstable? |
This error seems to be something from PDM while fetching packages. In other words, it may be an intermittent loss of connection to the server hosting package files. I would expect that PDM has some retry logic, so this kind of error should be very rare, unless the package server is completely offline. I just restarted the job to try again. If it fails again, I think the cause is something else and will need to investigate. |
The job succeeded upon retry, so I think the remaining task is for me to check whether I need to enable Codecov with the tulip-control organization. |
@@ -26,6 +28,10 @@ plugins: | |||
markdown_extensions: | |||
- attr_list | |||
- md_in_html | |||
- pymdownx.arithmatex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which Python package includes this extension? In general, can you also write instructions for building the docs?
For this, I recommend to move the docs dependencies from docs/requirements.txt into pyproject.toml as optional dependencies following the example in the PDM docs. Then the building the docs instructions can be as simple as
pdm install -G docs
mkdocs build
@jgraeb I still encounter errors when trying to install it. I will investigate more in the next few days, but for this PR, if the code is working for you locally, I think that you can address my comments and then squash-merge this into the I suggest squash-merge so that all of the commits are combined into a single commit, because the sequence of commits of this PR seems to have duplicates and other changes that are not likely to be useful to look back on later (compared with the PR as a whole). |
Co-authored-by: Scott C. Livingston <[email protected]>
Co-authored-by: Scott C. Livingston <[email protected]>