cases: bounding box for unbounded polytope, bounding box for empty polytope #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slivingston
approved these changes
Feb 22, 2024
`-np.inf` used as lower bound when unbounded from below, and `np.inf` as upper bound when unbounded from above. For an empty polytope, 0 is used as both bounds.
In `matplotlib > 3.5.3`, the parameter `closed` of `matplotlib.patches.Polygon.__init__()` is a keyword-only argument.
johnyf
force-pushed
the
inf_bounding_box
branch
from
6fc845c to
5a125cb
Compare
|
Thank you for reviewing the changes, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unbounded polytope, the bounding box has infinite dimensions. For an empty polytope the bounding box is 0, 0. This change follows commit 7f59645, before which 0, 0 were used as endpoints in all these cases. In
tuliprelevant tests pass with these changes.