H5p version in path breaks it

[Jakeii]

In the h5ps that Luka sent me for the course with reading section demo there seemed to be versions in the path.

atm it will probably just have work with the new version, till I can figure a way to be backwards compatible. h5p/h5p-editor-php-library#18

[mgancarzdsi]

Hi Jake, FYI we're discussing your h5p-standalone tool on the H5P forums here: https://h5p.org/node/22947 and I'm really excited as it has the potential to allow us to directly embed h5p activites in a Lectora package or other places where we just want plain html presentation without requiring a CMS.

I'm testing it now with our h5p files, and it works as long as I remove the version numbers on the end of the library files after extracting the h5p file into workspace. I am also testing this version you've tweaked to account for the version being in the path, but I am having some trouble with it, as it's missing the h5p-standalone-main.min.js file and when I manually create one by just copying h5p-standalone-main.js it gives me errors:
"h5p-standalone-main.min.js:9592 Uncaught (in promise) TypeError: h5p.preloadedDependencies.findBy is not a function(…)(anonymous function) @ h5p-standalone-main.min.js:9592"

[mgancarzdsi]

Also, kudos on the work you've already done on this! It's really appreciated 👍

[Jakeii]

Hi Mathew! Thanks for checking this out, I'm not sure how that findBy made it in there, it should be working now.

see here to see how we're using it if you're interested.

[Jakeii]

Hi @mgancarzdsi I think I found a solution, any chance that you have time to test?

[mgancarzdsi]

Sure @Jakeii, do you want me to just check out this branch or which code do you want me to test with?

[Jakeii]

Yes just check out this branch and make sure it works for you if you could,
if you have a projects with both kinds of paths (with/without versions)

On Wed, 26 Oct 2016, 19:13 Mathew Gancarz, [email protected] wrote:

Sure @Jakeii https://github.com/Jakeii, do you want me to just check
out this branch or which code do you want me to test with?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABpqTiea5gGHnyXEtrikACekYeZDGX5uks5q35gwgaJpZM4KQ-cv
.

[mgancarzdsi]

Hi Jakeii, confirmed working for h5p activities with versions in path, and also when I manually remove versions #'s from the folders. I don't have a genuine old activity to test with, but I think that's close enough.

[mgancarzdsi]

Great work on fixing it btw 👍

[Jakeii]

Sweet thanks @mgancarzdsi !