Use Transform API for MpegTsDemuxer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original TSDemuxer API used a callback parameter to emit extracted Packets. This replaces that with NodeJS's built in Transform Stream API. https://nodejs.org/api/stream.html#stream_class_stream_transform Really what's happening is that: 1) We hijacked `cb` to insteadp invoke `push` 2) `process` is now private and only invoked from _transform 3) `finalize` is now private and only invoked from _flush Issue #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the old
callbackpattern with the shinyTransform StreampatternMpegTsDemuxer should now be treated as a Duplex stream -- it can be used as part of a pipeline.
Related Issues
Resolves #7