Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert draw functions: alter parameters only #101

Merged
merged 12 commits into from
Oct 8, 2024
Merged

Conversation

twallema
Copy link
Owner

@twallema twallema commented Oct 8, 2024

  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.

Describe your fixes/additions/changes

Following #99, altering the initial condition thru the draw functions has become redundant. Draw functions now have their original format,

draw_function(parameters, par_1, par_2):
    # make alteration to parameter dictionary
   return parameters

where par_1 and par_2 have to be provided to the sim() function thru the draw_function_kwargs. To alter an initial condition, use an initial condition function (see PR #99) with arguments. Because these arguments become model parameters, they can be altered through the draw function.

@twallema twallema merged commit d64ecd1 into master Oct 8, 2024
2 checks passed
@twallema twallema deleted the revert-draw-functions branch October 8, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant