Address warnings + remove warning suppression #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your fixes/additions/changes
In the tutorials, warnings were suppressed using the following code:
However, suppressing warnings is undesirable. So I've gone through all the unit tests and tutorials, removed any warning suppression, and addressed one warning that popped up. In
~/influenza_1718/calibration.py
,was changed into,
because pandas threw a warning that it had trouble parsing the dates. Only two warnings that don't require further attention remain (listing them here for bookkeeping purposes):
workflow_tutorial.py
, when printing the autocorrelation of the MCMC sampler, this yields a divide by zero/overflow warning (see below). I looked in theemcee
code to study the error, and it is caused by the first autocorrelation being zero. Idk why this is zero tho, played with the perturbation on the initial estimate, etc. Chains don't go out of bounds, really weird but it's only present in this tutorial so I'm leaving it like this./home/twallema/anaconda3/envs/PYSODM/lib/python3.12/site-packages/emcee/autocorr.py:38: RuntimeWarning: invalid value encountered in divide acf /= acf[0]