Use nplog1p in poisson/negbinom likelihood function #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your fixes/additions/changes
In
ll_poisson
andll_negative_binomial
, there was a test to see if theydata
orymodel
were smaller than or equal to one. If this was the case, then the minimal model/data point were found and raised to 1e-6. This is,ymodel
andydata
.So now, by default, in
ll_poisson
andll_negative_binomial
,I've verified this gives the same results in the workflow & influenza 17-18 tutorial.