Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retaining floats in function list_to_dict in log posterior probability function #90

Merged

Conversation

twallema
Copy link
Owner

@twallema twallema commented Sep 6, 2024

  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.

Describe your fixes/additions/changes

Calibrated parameters

In #84 the default behavior of list_to_dict when encountering a float was changed to retain_floats=False bc this made more sense in the context of simulations. However, list_to_dict is also used in the computation of the log posterior probability and there it makes more sense to have retain_floats = True.

This PR changes the behavior of the list_to_dict called in the log posterior probability function to retain_floats=True. The default setting however remains retain_floats=False.

@twallema twallema merged commit 4e8b1ca into master Sep 6, 2024
2 checks passed
@twallema twallema deleted the enable-retain-floats-in-posterior-probability-function branch September 6, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant