-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont check in the grammar, but generate it at release time #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch | dont-check-in-the-grammar |
Testbed | ubuntu-latest |
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
fibonacci 10 | 📈 view plot 🚷 view threshold | 495.93 |
foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,712.30 |
foldl arrays 500 | 📈 view plot 🚷 view threshold | 6,863.30 |
foldr strings 50 | 📈 view plot 🚷 view threshold | 7,304.10 |
foldr strings 500 | 📈 view plot 🚷 view threshold | 63,998.00 |
generate normal 250 | 📈 view plot 🚷 view threshold | 41,722.00 |
generate normal 50 | 📈 view plot 🚷 view threshold | 1,976.40 |
generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 3,342.90 |
generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 781.65 |
pidigits 100 | 📈 view plot 🚷 view threshold | 3,188.80 |
pipe normal 20 | 📈 view plot 🚷 view threshold | 1,534.30 |
pipe normal 200 | 📈 view plot 🚷 view threshold | 10,345.00 |
product 30 | 📈 view plot 🚷 view threshold | 849.40 |
scalar 10 | 📈 view plot 🚷 view threshold | 1,524.20 |
sum 30 | 📈 view plot 🚷 view threshold | 826.42 |
yannham
reviewed
Jan 27, 2025
47f1001
to
c7267b4
Compare
yannham
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2141, that avoids checking in a 22MB generated file. Here, we generate the grammar at
cargo publish
time. The main disadvantage of this one is that it's hard to test: although I've tested the individual commands, I haven't tested the release script as a whole because I didn't want to push changes to thestable
branch.I've simplified the build script so that it doesn't try to check the freshness of the generated grammar: it assumes that if there's a generated grammar already present then it's fresh. In principle the published crate could have an even simpler build process (with no build-dependency on lalrpop) but that would introduce more hard-to-test release stuff so I haven't gone that route.