Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont check in the grammar, but generate it at release time #2145

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

jneem
Copy link
Member

@jneem jneem commented Jan 24, 2025

This is an alternative to #2141, that avoids checking in a 22MB generated file. Here, we generate the grammar at cargo publish time. The main disadvantage of this one is that it's hard to test: although I've tested the individual commands, I haven't tested the release script as a whole because I didn't want to push changes to the stable branch.

I've simplified the build script so that it doesn't try to check the freshness of the generated grammar: it assumes that if there's a generated grammar already present then it's fresh. In principle the published crate could have an even simpler build process (with no build-dependency on lalrpop) but that would introduce more hard-to-test release stuff so I haven't gone that route.

@jneem jneem requested review from yannham and aspiwack January 24, 2025 05:00
scripts/release.sh Outdated Show resolved Hide resolved
scripts/release.sh Show resolved Hide resolved
core/build.rs Show resolved Hide resolved
@jneem jneem force-pushed the dont-check-in-the-grammar branch from 47f1001 to c7267b4 Compare January 28, 2025 02:52
@jneem jneem added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit b4eade6 Jan 28, 2025
5 checks passed
@jneem jneem deleted the dont-check-in-the-grammar branch January 28, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants