Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pull diagnostics and use them for testing #2166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jneem
Copy link
Member

@jneem jneem commented Feb 12, 2025

Push diagnostics (where the LSP decides when to publish, and sends notifications) are hard to test reliably, because the harness doesn't know when and how many diagnostics to expect.

This PR adds support for "pull" diagnostics, where there's a diagnostic request and the server responds to it. This simplifies the testing, and hopefully stops it from timing out at random.

This will probably conflict with the typechecker changes. I'm happy to wait and rebase.

@jneem jneem requested a review from yannham February 12, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant