[RFC007] Migration of the typechecker part II - focus on bytecode::ast::typecheck
#2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
rfc007/typechecking-part-2a
branch
5 times, most recently
from
9147d19 to
5ed246e
Compare
|
Bencher Report| Branch | rfc007/typechecking-part-2a |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| fibonacci 10 | 📈 view plot 🚷 view threshold | 384.39 |
| foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,601.90 |
| foldl arrays 500 | 📈 view plot 🚷 view threshold | 5,867.30 |
| foldr strings 50 | 📈 view plot 🚷 view threshold | 5,828.80 |
| foldr strings 500 | 📈 view plot 🚷 view threshold | 50,200.00 |
| generate normal 250 | 📈 view plot 🚷 view threshold | 44,705.00 |
| generate normal 50 | 📈 view plot 🚷 view threshold | 1,903.40 |
| generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 2,761.40 |
| generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 648.10 |
| pidigits 100 | 📈 view plot 🚷 view threshold | 2,735.80 |
| pipe normal 20 | 📈 view plot 🚷 view threshold | 1,297.10 |
| pipe normal 200 | 📈 view plot 🚷 view threshold | 8,431.80 |
| product 30 | 📈 view plot 🚷 view threshold | 744.04 |
| scalar 10 | 📈 view plot 🚷 view threshold | 1,298.10 |
| sum 30 | 📈 view plot 🚷 view threshold | 738.38 |
yannham
force-pushed
the
rfc007/typechecking-part-2a
branch
from
5ed246e to
c3df626
Compare
This commit is a backport of many fixes that were done as part of testing the new typecheck module that operates on the new AST representation. This commit doesn't yet switch the default typechecker to the new one, which requires to deeply change the `Cache` structures and the LSP as well, which are still operating on the old representation. It also includes a bunch of new helpers for some AST data structures.
yannham
force-pushed
the
rfc007/typechecking-part-2a
branch
from
c3df626 to
285b67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the name, it is not very inspired. This PR is a split of the behemoth of #2134 that has become unmanageable, leading to unexpected and mandatory changes to many parts of Nickel. The current PR only keeps the changes to
bytecode::ast, and doesn't actually get rid of the old typechecker, but instead only modifiesbytecode::ast::typecheck.The changes that landed here comes from actually testing the new typechecker, making all the tests of
nickel-lang-corepass. It also includes various helpers additions to thebytecode::astmodule.