Migrate right drawer record page to the command menu #9459
Merged
+422
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR migrates the right drawer record page functionality into the command menu system, replacing the page header V2 feature flag with a new command menu V2 flag across the codebase.
- Added new
CommandMenuRouterand pages configuration to handle record views within command menu instead of right drawer - Modified
useRightDrawerhook to open command menu instead of drawer whenIsCommandMenuV2Enabledflag is true - Added
CommandMenuPagesenum and state management for routing between root and view-record pages - Refactored
CommandMenuContainerto use children pattern and handle click-outside behavior - Updated hotkey scopes across activity components to use
CommandMenuOpeninstead ofRightDrawerwhen new flag is enabled
32 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuContainer.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/constants/CommandMenuPagesConfig.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuRouter.tsx
Show resolved
Hide resolved
.../twenty-front/src/modules/object-record/record-right-drawer/components/RightDrawerRecord.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/hooks/useRightDrawer.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageAddButton.tsx
Show resolved
Hide resolved
thomtrp
approved these changes
Jan 9, 2025
| @@ -0,0 +1,4 @@ | |||
| export enum CommandMenuPages { | |||
| Root = 'root', | |||
| ViewRecord = 'view-record', | |||
There was a problem hiding this comment.
is it a global name for record details on right drawer?
There was a problem hiding this comment.
Yes, I took the same terminology as in the RightDrawerPages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9423
Enregistrement.de.l.ecran.2025-01-08.a.16.46.59.mov