Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): update SAML strategy configuration #9829

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore(auth): update SAML strategy configuration #9829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/twenty-server/src/engine/core-modules/auth/strategies/saml.auth.strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ export class SamlAuthStrategy extends PassportStrategy(
issuer: this.sSOService.buildIssuerURL(identityProvider),
callbackUrl: this.sSOService.buildCallbackUrl(identityProvider),
idpCert: identityProvider.certificate,
wantAssertionsSigned: false,
// TODO: Improve the feature by sign the response
wantAssertionsSigned: false,
wantAuthnResponseSigned: false,
disableRequestedAuthnContext: true,
Comment on lines 39 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: All signature verification is disabled and AuthnContext is now disabled. This reduces security. Consider enabling at least one form of signature verification.

signatureAlgorithm: 'sha256',
};

Expand Down
Loading