Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong label formatting #9830

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix wrong label formatting #9830

merged 1 commit into from
Jan 24, 2025

Conversation

martmull
Copy link
Contributor

@martmull martmull mentioned this pull request Jan 24, 2025
Open
greptile-apps[bot]
greptile-apps bot reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR improves the header label formatting in workflow variable dropdowns by utilizing schema labels for better readability.

  • Modified getHeaderLabel() in /packages/twenty-front/src/modules/workflow/workflow-variables/components/WorkflowVariablesDropdownFieldItems.tsx to properly handle record output schema cases
  • Added schema label fallback logic to display more user-friendly field names instead of raw camelCase values
  • Fixed visual inconsistency in dropdown headers when navigating through nested workflow variables

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

...t/src/modules/workflow/workflow-variables/components/WorkflowVariablesDropdownFieldItems.tsx Show resolved Hide resolved
bosiraphael
bosiraphael approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martmull martmull merged commit 1a42483 into main Jan 24, 2025
47 checks passed
@martmull martmull deleted the fix-variable-composite-field-name-should-not-be-camelcase branch January 24, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@bosiraphael bosiraphael bosiraphael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martmull @bosiraphael