Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Python ingress changes #548

Merged
merged 25 commits into from
Dec 14, 2023
Merged

chore: Python ingress changes #548

merged 25 commits into from
Dec 14, 2023

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 marked this pull request as draft November 29, 2023 10:36
@tiwarishubham635 tiwarishubham635 marked this pull request as ready for review December 5, 2023 05:43
manisha1997
manisha1997 requested changes Dec 5, 2023
View reviewed changes
src/test/java/com/twilio/oai/TwilioGeneratorTest.java Outdated
@@ -49,6 +42,8 @@ public static void setUp() {
public void launchGenerator() {
final String pathname = "examples/spec/twilio_api_v2010.yaml";
// final String pathname = "examples/twilio_messaging_bulk_v1.yaml";
// final String pathname = "/Users/stiwari/di/github/twilio-oai/spec/yaml/twilio_messaging_bulk_v1.yaml";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some local references

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I will remove them

src/test/java/com/twilio/oai/TwilioGeneratorTest.java Outdated
Generator.TWILIO_PYTHON,
Generator.TWILIO_RUBY,
Generator.TWILIO_TERRAFORM);
return Arrays.asList(Generator.TWILIO_PYTHON);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

manisha1997
manisha1997 requested changes Dec 5, 2023
View reviewed changes
src/main/java/com/twilio/oai/resolver/python/PythonCodegenModelContainerDataTypeResolver.java
import java.util.Stack;
import java.util.regex.Pattern;

public class PythonCodegenModelContainerDataTypeResolver extends CodegenModelContainerDataTypeResolver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add javadoc

manisha1997
manisha1997 requested changes Dec 5, 2023
View reviewed changes
src/main/java/com/twilio/oai/resolver/python/PythonCodegenModelDataTypeResolver.java
import java.util.function.BiConsumer;

// Overriding default behavior and handling the enum
public class PythonCodegenModelDataTypeResolver extends CodegenModelDataTypeResolver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#548 (comment)

src/main/java/com/twilio/oai/resolver/python/PythonCodegenModelResolver.java
import java.util.List;
import java.util.Map;

public class PythonCodegenModelResolver extends CodegenModelResolver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#548 (comment)

@tiwarishubham635
Copy link
Contributor Author

C# tests are failing as sonar requires minimum java 17 version. See this

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-php'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-ruby'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-go'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-java'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-node'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635
Copy link
Contributor Author

The C# tests are passing locally, maybe we can look into updating the sonar config.

@tiwarishubham635 tiwarishubham635 merged commit 33a987d into main Dec 14, 2023
20 of 22 checks passed
@tiwarishubham635 tiwarishubham635 deleted the python_ingress_changes branch December 14, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manisha1997 manisha1997 manisha1997 requested changes

@kridai kridai kridai approved these changes

@shrutiburman shrutiburman shrutiburman approved these changes

@AsabuHere AsabuHere Awaiting requested review from AsabuHere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiwarishubham635 @kridai @manisha1997 @shrutiburman