Sentry にユーザ情報を追加 #674
Merged
Sentry にユーザ情報を追加 #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HosokawaR
reviewed
Apr 7, 2023
src/ui/templates/Layout.vue
Outdated
Comment on lines
35
to
36
| ports.userRepository | ||
| .getUser() |
There was a problem hiding this comment.
#673 (comment) と同様に UseCase を介して参照し、現行のアーキテクチャに合わせたいです。
ただ現在は User を取得する UseCase が存在しないので、手間ですがそれも合わせて作る必要があります。
There was a problem hiding this comment.
現在のアーキテクチャだとUseCaseを介す必要があります。
ただ、めんどくさいんですよね。何かいい方法があれば言ってください！
hayato24s
approved these changes
Apr 7, 2023
|
@kichi2004 フィードバックがあったときに、User ID でエラーログが残っていないか確かめたいことが多く、早めに Merge できるといいなと考えています。 |
|
@HosokawaR 修正しましたので確認お願いします！ |
HosokawaR
approved these changes
Apr 18, 2023
|
ちょうどユーザ数が少なそうでデプロイにいい時間帯なのでこちらで Merge & Deploy しちゃいますね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry.setUserを使ってユーザ情報を追加これでうまく動くかはわからないので様子見が必要かもしれないです