-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 20.6 (old branch) #329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 48 48
Lines 3928 3928
Branches 262 262
=======================================
Hits 3856 3856
Misses 55 55
Partials 17 17
Continue to review full report at Codecov.
|
It pretty much works, but it has basically zero test coverage, and I don't have a ton of time to work on it right now. I would not want to hold up any releases because of it. If someone were to really need such a thing on python 2 after the fact, they can grab the version from that branch. But I think the main point with py2 at this point is compatibility, so I doubt anyone interested in building a major new database-backed system with Klein would want to start there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm going to drop the idea of getting type hints into this release for Python 2.4 users. |
@@ -1,6 +1,36 @@ | |||
NEWS | |||
==== | |||
|
|||
20.6.0 - 2020-06-?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the date before releasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I only had minor notes.
I will probably cargo-cult release.py
into Treq since it's a better version of the script I was going to write. Would you mind slapping a copyright/license header on it?
I'm looking forward to the release!
* master: Remove a bunch of "type: ignore[misc]" comments for Zope interface uses that are no longer triggering mypy, and change calls to interface types to ""type: ignore[operator]". Add updates missed by requires.io Ignore /docs/ [requires.io] dependency update [requires.io] dependency update
@twm I was thinking about factoring out |
yessssssssssss |
Renamed the branch, which is now PR #353 |
This PR is a Klein 20.6 release.
The primary goal for this release is to ship all work that's currently been done with support for Python 2.7 before we drop support for Python 2.7, so that we leave the 2.7 users with the latest available progress.
In addition to incrementing the version, this PR adds a script for automating the release process.