CET-510/fix: Fix magento calculations #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkwr
force-pushed
the
brtkwr-two/cet-510-fix-magento-calculations
branch
from
704e053 to
2a7bc5f
Compare
brtkwr
force-pushed
the
brtkwr-two/cet-510-fix-magento-calculations
branch
6 times, most recently
from
3f9ecee to
05e4b56
Compare
At present, we derive the gross amount for line item. This is causing rounding error in some cases. Instead we should use gross amount provided by Magento.
brtkwr
force-pushed
the
brtkwr-two/cet-510-fix-magento-calculations
branch
from
05e4b56 to
c527cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, we derive the gross amount for line item. This is causing rounding error in some cases.
Instead we should use gross amount provided by magento