Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Major revamp #1487

Closed
wants to merge 253 commits into from
Closed

Conversation

shenshaw26
Copy link
Contributor

Working to separate Launcher from execution engine.

Started with MNIST Baseline:
armory-launcher -v run ./tests/scenarios/experiments/base_image_classification.aexp --override model.fit_kwargs.nb_epochs=1 --override execution.mode=native which as of 3d80805b13868943a2dc61db89ff45dc1277b661 worked successfully

mwartell and others added 30 commits February 8, 2022 10:58
add function to add new sinks
the log from CI shows an upgrade/downgrade for numpy
ending with 1.19.5
this may be the cause of the CI fault
Seth Henshaw added 5 commits May 2, 2022 11:32
…ts/scenarios/experiments/base_image_classification.aexp --override model.fit_kwargs.nb_epochs=1 --override execution.mode=native
@shenshaw26
Copy link
Contributor Author

shenshaw26 commented May 3, 2022

@davidslater, still a long way to go here, but this at least works with baseline MNIST in native mode. I am going to move on to making it work in Docker and then will work to clean up implementation. Just wanted to get you something to start looking at as I wrap it up.

@davidslater
Copy link
Contributor

@shenshaw26 can you update to black 22.3? (This was part of the 0.15.0 release update). It will make it a lot easier to parse the changes you've made here.

@shenshaw26
Copy link
Contributor Author

@shenshaw26 can you update to black 22.3? (This was part of the 0.15.0 release update). It will make it a lot easier to parse the changes you've made here.

Will do!!

@davidslater
Copy link
Contributor

I'm having a hard time parsing the changes - it won't even load in my browser. Can you point me to the most relevant files?

@davidslater
Copy link
Contributor

Add click to one of the requirements files.

@mwartell mwartell self-assigned this May 13, 2022
@mwartell
Copy link
Collaborator

Obsoleted by #1696 which aims for the same goal with a more staged approach than was done here.

@mwartell mwartell closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants