Feat/starknet #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +44,8 @@ | |||
| "eslint-plugin-import": "^2.31.0", | |||
| "mocha": "^10.2.0", | |||
| "prettier": "^2.8.8", | |||
| "typescript": "5.3.3" | |||
| "typescript": "5.3.3", | |||
| "zksync-ethers": "^5.10.0" | |||
There was a problem hiding this comment.
Maybe we should keep zksync-ethers away from PR and not presume it will get merges to main before this branch?
| switch (protocol) { | ||
| case ProtocolType.Ethereum: | ||
| return async () => { | ||
| return ethers.providers.JsonRpcProvider.defaultUrl(); |
There was a problem hiding this comment.
What exactly is the purpose of calling defaultUrl() method in this case?
There was a problem hiding this comment.
Good catch, it is returning default RPC url of chain, maybe better to rename function.
There was a problem hiding this comment.
Too many changes in this file
| case IsmType.MERKLE_ROOT_MULTISIG: | ||
| case IsmType.MESSAGE_ID_MULTISIG: | ||
| constructorArgs = [ | ||
| this.account.address, |
There was a problem hiding this comment.
As far as I see, the owner param on cairo contract is only used in constructor, so I would ignore pulling the owner address from config for now
There was a problem hiding this comment.
the problem is some ISMs are own able on Starknet and not own able on evm
| config.requiredHook.type === HookType.PROTOCOL_FEE, | ||
| 'only protocolFee hook is accepted for required hook', | ||
| ); | ||
| const noopIsm = await this.deployer.deployContract('noop_ism', []); |
There was a problem hiding this comment.
If there is always the defaultISM, I would rather use that one instead of first deploying noop_ism, and then later deploying defaultISM (which seems to be the case here)
There was a problem hiding this comment.
As you can see below, default Ism deployment, requires mailbox address,
const defaultIsm = await this.deployer.deployIsm({
chain: args.chain.toString(),
ismConfig: expectedConfig.defaultIsm,
mailbox: args.mailboxContract.address,
});
So I am more in this noop ism deployment approtch.
There was a problem hiding this comment.
Default ISM deployment requires mailbox, so I am more into deploying noop ism first, specially there could be times user do not specify any ism!
| '0', | ||
| config.requiredHook.beneficiary, | ||
| config.owner, | ||
| '0x49D36570D4E46F48E99674BD3FCC84644DDD6B96F7C741B1562B82F9E004DC7', // ETH address on Starknet chains |
There was a problem hiding this comment.
Do all Starknet chains have this address as ETH token? If not, can se put specify it in registry init command?
There was a problem hiding this comment.
I guess they are all same, but not really sure where can we verify this.
…t/starknet-collateral-warp
feat: starknet send message
… read from config
ljankovic-txfusion
force-pushed
the
main
branch
from
db616cc to
f1745f9
Compare
ljankovic-txfusion
pushed a commit
that referenced
this pull request
Feb 20, 2025
…ne-xyz#5468) ### Description - More frequent retries for the first ~30 mins, meant to accommodate the upcoming CCIP ISM which is known to take ~25 mins on some origins After this change: ``` Retry #0: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:0 Retry #1: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:10 Retry #2: cumulative duration from beginning is 0:0:10, since last attempt is 0:0:10 Retry #3: cumulative duration from beginning is 0:0:20, since last attempt is 0:0:10 Retry #4: cumulative duration from beginning is 0:0:30, since last attempt is 0:0:10 Retry #5: cumulative duration from beginning is 0:0:40, since last attempt is 0:0:10 Retry #6: cumulative duration from beginning is 0:0:50, since last attempt is 0:0:10 Retry #7: cumulative duration from beginning is 0:1:0, since last attempt is 0:0:10 Retry #8: cumulative duration from beginning is 0:1:10, since last attempt is 0:0:10 Retry #9: cumulative duration from beginning is 0:1:20, since last attempt is 0:0:10 Retry #10: cumulative duration from beginning is 0:1:30, since last attempt is 0:1:30 Retry #11: cumulative duration from beginning is 0:3:0, since last attempt is 0:1:30 Retry #12: cumulative duration from beginning is 0:4:30, since last attempt is 0:1:30 Retry #13: cumulative duration from beginning is 0:6:0, since last attempt is 0:1:30 Retry #14: cumulative duration from beginning is 0:7:30, since last attempt is 0:1:30 Retry #15: cumulative duration from beginning is 0:9:0, since last attempt is 0:2:0 Retry #16: cumulative duration from beginning is 0:11:0, since last attempt is 0:2:0 Retry #17: cumulative duration from beginning is 0:13:0, since last attempt is 0:2:0 Retry #18: cumulative duration from beginning is 0:15:0, since last attempt is 0:2:0 Retry #19: cumulative duration from beginning is 0:17:0, since last attempt is 0:2:0 Retry #20: cumulative duration from beginning is 0:19:0, since last attempt is 0:2:0 Retry #21: cumulative duration from beginning is 0:21:0, since last attempt is 0:2:0 Retry #22: cumulative duration from beginning is 0:23:0, since last attempt is 0:2:0 Retry #23: cumulative duration from beginning is 0:25:0, since last attempt is 0:2:0 Retry #24: cumulative duration from beginning is 0:27:0, since last attempt is 0:2:0 Retry #25: cumulative duration from beginning is 0:29:0, since last attempt is 0:3:0 Retry hyperlane-xyz#26: cumulative duration from beginning is 0:32:0, since last attempt is 0:4:30 Retry hyperlane-xyz#27: cumulative duration from beginning is 0:36:30, since last attempt is 0:6:0 Retry hyperlane-xyz#28: cumulative duration from beginning is 0:42:30, since last attempt is 0:7:30 Retry hyperlane-xyz#29: cumulative duration from beginning is 0:50:0, since last attempt is 0:9:0 Retry hyperlane-xyz#30: cumulative duration from beginning is 0:59:0, since last attempt is 0:10:30 Retry hyperlane-xyz#31: cumulative duration from beginning is 1:9:30, since last attempt is 0:12:0 Retry hyperlane-xyz#32: cumulative duration from beginning is 1:21:30, since last attempt is 0:13:30 Retry hyperlane-xyz#33: cumulative duration from beginning is 1:35:0, since last attempt is 0:15:0 Retry hyperlane-xyz#34: cumulative duration from beginning is 1:50:0, since last attempt is 0:16:30 Retry hyperlane-xyz#35: cumulative duration from beginning is 2:6:30, since last attempt is 0:18:0 Retry hyperlane-xyz#36: cumulative duration from beginning is 2:24:30, since last attempt is 0:19:30 Retry hyperlane-xyz#37: cumulative duration from beginning is 2:44:0, since last attempt is 0:21:0 Retry hyperlane-xyz#38: cumulative duration from beginning is 3:5:0, since last attempt is 0:22:30 Retry hyperlane-xyz#39: cumulative duration from beginning is 3:27:30, since last attempt is 0:24:0 Retry hyperlane-xyz#40: cumulative duration from beginning is 3:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#41: cumulative duration from beginning is 4:21:30, since last attempt is 0:30:0 Retry hyperlane-xyz#42: cumulative duration from beginning is 4:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#43: cumulative duration from beginning is 5:21:30, since last attempt is 0:30:0 Retry hyperlane-xyz#44: cumulative duration from beginning is 5:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#45: cumulative duration from beginning is 6:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#46: cumulative duration from beginning is 7:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#47: cumulative duration from beginning is 8:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#48: cumulative duration from beginning is 9:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#49: cumulative duration from beginning is 10:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#50: cumulative duration from beginning is 11:21:30, since last attempt is 2:38:56 Retry hyperlane-xyz#51: cumulative duration from beginning is 14:0:26, since last attempt is 8:6:55 Retry hyperlane-xyz#52: cumulative duration from beginning is 22:7:21, since last attempt is 8:24:34 Retry hyperlane-xyz#53: cumulative duration from beginning is 30:31:55, since last attempt is 12:32:21 Retry hyperlane-xyz#54: cumulative duration from beginning is 43:4:16, since last attempt is 15:56:31 Retry hyperlane-xyz#55: cumulative duration from beginning is 59:0:47, since last attempt is 15:29:51 Retry hyperlane-xyz#56: cumulative duration from beginning is 74:30:38, since last attempt is 14:13:18 Retry hyperlane-xyz#57: cumulative duration from beginning is 88:43:56, since last attempt is 16:55:33 Retry hyperlane-xyz#58: cumulative duration from beginning is 105:39:29, since last attempt is 22:51:56 Retry hyperlane-xyz#59: cumulative duration from beginning is 128:31:25, since last attempt is 23:20:42 Retry hyperlane-xyz#60: cumulative duration from beginning is 151:52:7, since last attempt is 24:5:0 Retry hyperlane-xyz#61: cumulative duration from beginning is 175:57:7, since last attempt is 26:51:36 Retry hyperlane-xyz#62: cumulative duration from beginning is 202:48:43, since last attempt is 30:55:26 Retry hyperlane-xyz#63: cumulative duration from beginning is 233:44:9, since last attempt is 32:33:46 Retry hyperlane-xyz#64: cumulative duration from beginning is 266:17:55, since last attempt is 33:58:37 Retry hyperlane-xyz#65: cumulative duration from beginning is 300:16:32, since last attempt is 35:31:14 Retry hyperlane-xyz#66: cumulative duration from beginning is 335:47:46, since last attempt is 38:37:22 Retry hyperlane-xyz#67: cumulative duration from beginning is 374:25:8, since last attempt is 36:1:47 Retry hyperlane-xyz#68: cumulative duration from beginning is 410:26:55, since last attempt is 42:42:1 Retry hyperlane-xyz#69: cumulative duration from beginning is 453:8:56, since last attempt is 42:7:4 Retry hyperlane-xyz#70: cumulative duration from beginning is 495:16:0, since last attempt is 47:45:25 Retry hyperlane-xyz#71: cumulative duration from beginning is 543:1:25, since last attempt is 47:20:15 Retry hyperlane-xyz#72: cumulative duration from beginning is 590:21:40, since last attempt is 50:42:29 Retry hyperlane-xyz#73: cumulative duration from beginning is 641:4:9, since last attempt is 50:36:53 Retry hyperlane-xyz#74: cumulative duration from beginning is 691:41:2, since last attempt is 53:25:8 Retry hyperlane-xyz#75: cumulative duration from beginning is 745:6:10, since last attempt is 54:32:25 Retry hyperlane-xyz#76: cumulative duration from beginning is 799:38:35, since last attempt is 55:46:58 Retry hyperlane-xyz#77: cumulative duration from beginning is 855:25:33, since last attempt is 59:21:28 Retry hyperlane-xyz#78: cumulative duration from beginning is 914:47:1, since last attempt is 58:47:29 Retry hyperlane-xyz#79: cumulative duration from beginning is 973:34:30, since last attempt is 63:38:16 Retry hyperlane-xyz#80: cumulative duration from beginning is 1037:12:46, since last attempt is 64:29:15 Retry hyperlane-xyz#81: cumulative duration from beginning is 1101:42:1, since last attempt is 66:44:38 Retry hyperlane-xyz#82: cumulative duration from beginning is 1168:26:39, since last attempt is 67:13:25 Retry hyperlane-xyz#83: cumulative duration from beginning is 1235:40:4, since last attempt is 71:38:16 Retry hyperlane-xyz#84: cumulative duration from beginning is 1307:18:20, since last attempt is 70:59:58 Retry hyperlane-xyz#85: cumulative duration from beginning is 1378:18:18, since last attempt is 73:16:27 Retry hyperlane-xyz#86: cumulative duration from beginning is 1451:34:45, since last attempt is 75:50:17 Retry hyperlane-xyz#87: cumulative duration from beginning is 1527:25:2, since last attempt is 80:23:55 Retry hyperlane-xyz#88: cumulative duration from beginning is 1607:48:57, since last attempt is 81:41:11 Retry hyperlane-xyz#89: cumulative duration from beginning is 1689:30:8, since last attempt is 83:48:29 Retry hyperlane-xyz#90: cumulative duration from beginning is 1773:18:37, since last attempt is 82:24:16 Retry hyperlane-xyz#91: cumulative duration from beginning is 1855:42:53, since last attempt is 88:31:19 Retry hyperlane-xyz#92: cumulative duration from beginning is 1944:14:12, since last attempt is 88:53:21 Retry hyperlane-xyz#93: cumulative duration from beginning is 2033:7:33, since last attempt is 91:55:18 Retry hyperlane-xyz#94: cumulative duration from beginning is 2125:2:51, since last attempt is 90:38:51 Retry hyperlane-xyz#95: cumulative duration from beginning is 2215:41:42, since last attempt is 96:53:4 Retry hyperlane-xyz#96: cumulative duration from beginning is 2312:34:46, since last attempt is 96:9:40 Retry hyperlane-xyz#97: cumulative duration from beginning is 2408:44:26, since last attempt is 99:26:42 Retry hyperlane-xyz#98: cumulative duration from beginning is 2508:11:8, since last attempt is 98:48:58 Retry hyperlane-xyz#99: cumulative duration from beginning is 2607:0:6, since last attempt is 102:43:45 ``` Before: ``` 0: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:0 1: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:10 2: cumulative duration from beginning is 0:0:10, since last attempt is 0:0:10 3: cumulative duration from beginning is 0:0:20, since last attempt is 0:0:10 4: cumulative duration from beginning is 0:0:30, since last attempt is 0:0:10 5: cumulative duration from beginning is 0:0:40, since last attempt is 0:0:10 6: cumulative duration from beginning is 0:0:50, since last attempt is 0:0:10 7: cumulative duration from beginning is 0:1:0, since last attempt is 0:0:10 8: cumulative duration from beginning is 0:1:10, since last attempt is 0:0:10 9: cumulative duration from beginning is 0:1:20, since last attempt is 0:0:10 10: cumulative duration from beginning is 0:1:30, since last attempt is 0:0:10 11: cumulative duration from beginning is 0:1:40, since last attempt is 0:0:10 12: cumulative duration from beginning is 0:1:50, since last attempt is 0:1:30 13: cumulative duration from beginning is 0:3:20, since last attempt is 0:3:0 14: cumulative duration from beginning is 0:6:20, since last attempt is 0:4:30 15: cumulative duration from beginning is 0:10:50, since last attempt is 0:6:0 16: cumulative duration from beginning is 0:16:50, since last attempt is 0:7:30 17: cumulative duration from beginning is 0:24:20, since last attempt is 0:9:0 18: cumulative duration from beginning is 0:33:20, since last attempt is 0:10:30 19: cumulative duration from beginning is 0:43:50, since last attempt is 0:12:0 20: cumulative duration from beginning is 0:55:50, since last attempt is 0:13:30 21: cumulative duration from beginning is 1:9:20, since last attempt is 0:15:0 22: cumulative duration from beginning is 1:24:20, since last attempt is 0:16:30 23: cumulative duration from beginning is 1:40:50, since last attempt is 0:18:0 24: cumulative duration from beginning is 1:58:50, since last attempt is 0:30:0 25: cumulative duration from beginning is 2:28:50, since last attempt is 0:30:0 26: cumulative duration from beginning is 2:58:50, since last attempt is 0:30:0 27: cumulative duration from beginning is 3:28:50, since last attempt is 0:30:0 28: cumulative duration from beginning is 3:58:50, since last attempt is 0:30:0 29: cumulative duration from beginning is 4:28:50, since last attempt is 0:30:0 ``` ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing