-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSONC support and basic IDE settings for code style + fix output is created even though not specified #41
Merged
tyconsulting
merged 11 commits into
tyconsulting:master
from
o-l-a-v:jsonc-and-editorconfig
Dec 2, 2024
Merged
Add JSONC support and basic IDE settings for code style + fix output is created even though not specified #41
tyconsulting
merged 11 commits into
tyconsulting:master
from
o-l-a-v:jsonc-and-editorconfig
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamirHelez
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixed #43 in this PR too. |
o-l-a-v
changed the title
Add JSONC support and basic IDE settings for code style
Add JSONC support and basic IDE settings for code style + fix output is created even though not specified
Oct 23, 2024
thanks for the contribution. i've approved the PR and merged the code. I will create a new release in PSGallery in the coming days. i am adding an additional test too... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this PR was to add JSONC support, so this tool can be used with EPAC policies, which can do both JSON and JSONC.
I also added some basic VSCode settings for recommended extensions (PowerShell, EditorConfig) and for code style (to make sure my settings did not overwrite the style that was already present in this project).
What is EPAC:
EPAC has some validation during build and deploy, but it does not catch all problems. Thus AzPolicyTest would be great to have as part of the validation before build and deploy. Ref:
Convert-PolicyResourcesToDetails
in parallel does not throw if it fails Azure/enterprise-azure-policy-as-code#777This PR resolves following feature requests:
.editorconfig
so contributors follows code style #40This PR resolved following issues: