Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSONC support and basic IDE settings for code style + fix output is created even though not specified #41

Merged
merged 11 commits into from
Dec 2, 2024

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 18, 2024

The main objective of this PR was to add JSONC support, so this tool can be used with EPAC policies, which can do both JSON and JSONC.

I also added some basic VSCode settings for recommended extensions (PowerShell, EditorConfig) and for code style (to make sure my settings did not overwrite the style that was already present in this project).

What is EPAC:

EPAC has some validation during build and deploy, but it does not catch all problems. Thus AzPolicyTest would be great to have as part of the validation before build and deploy. Ref:

This PR resolves following feature requests:

This PR resolved following issues:

Copy link

@DamirHelez DamirHelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@o-l-a-v o-l-a-v requested a review from DamirHelez October 18, 2024 07:43
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 23, 2024

Fixed #43 in this PR too.

@o-l-a-v o-l-a-v changed the title Add JSONC support and basic IDE settings for code style Add JSONC support and basic IDE settings for code style + fix output is created even though not specified Oct 23, 2024
@tyconsulting tyconsulting merged commit 292f942 into tyconsulting:master Dec 2, 2024
@tyconsulting
Copy link
Owner

thanks for the contribution. i've approved the PR and merged the code. I will create a new release in PSGallery in the coming days. i am adding an additional test too...

@o-l-a-v o-l-a-v deleted the jsonc-and-editorconfig branch December 2, 2024 09:28
@tyconsulting tyconsulting mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants