Tighten regex for output assertion parsing #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `severity` group was permissive enough to also capture parts of the message text if that contained any colons. Update it to only capture (ASCII) words, and update preceding groups to match at least 1 character. Fixes typeddjango#155
mjpieters
force-pushed
the
mj/fix-regex-assertion-parsing
branch
from
e6837d2 to
2dfef3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
severitygroup was permissive enough to also capture parts of the message text if that contained any colons. Update it to only capture (ASCII) words, and update preceding groups to match at least 1 character.Fixes #155