fix(MongoInstance): kill the killerProcess on instance kill (#129)

typegoose · Jan 10, 2019 · 545d098 · 545d098
1 parent b59ed82
commit 545d098
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/util/MongoInstance.js b/src/util/MongoInstance.js
@@ -111,6 +111,12 @@ export default class MongodbInstance {
         this.childProcess.kill();
       });
     }
+    if (this.killerProcess && !(this.killerProcess: any).killed) {
+      await new Promise(resolve => {
+        this.killerProcess.once(`exit`, resolve);
+        this.killerProcess.kill();
+      });
+    }
     return this;
   }
 

diff --git a/src/util/__tests__/MongoInstance-test.js b/src/util/__tests__/MongoInstance-test.js
@@ -124,7 +124,9 @@ describe('MongoInstance', () => {
       binary: { version: 'latest' },
     });
     const pid: any = mongod.getPid();
+    const killerPid: any = mongod.killerProcess.pid;
     expect(pid).toBeGreaterThan(0);
+    expect(killerPid).toBeGreaterThan(0);
 
     function isPidRunning(p: number) {
       try {
@@ -135,8 +137,10 @@ describe('MongoInstance', () => {
     }
 
     expect(isPidRunning(pid)).toBeTruthy();
+    expect(isPidRunning(killerPid)).toBeTruthy();
     await mongod.kill();
     expect(isPidRunning(pid)).toBeFalsy();
+    expect(isPidRunning(killerPid)).toBeFalsy();
   });
 
   it('should work with mongodb 4.0.3', async () => {