Merge pull request #100 from jsasitorn/subcollection-guard

Move null filter in backfill to after await
typesense · Dec 19, 2024 · 61602aa · 61602aa
2 parents eb4c7a4 + 0f73ccc
commit 61602aa
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/functions/src/backfill.js b/functions/src/backfill.js
@@ -61,17 +61,20 @@ module.exports = functions.firestore.document(config.typesenseBackfillTriggerDoc
     if (thisBatch.empty) {
       break;
     }
-    const currentDocumentsBatch = await Promise.all(
-        thisBatch.docs.map(async (doc) => {
-          const docPath = doc.ref.path;
-          const pathParams = utils.pathMatchesSelector(docPath, config.firestoreCollectionPath);
-
-          if (!isGroupQuery || (isGroupQuery && pathParams !== null)) {
-            return await utils.typesenseDocumentFromSnapshot(doc, pathParams);
-          } else {
-            return null;
-          }
-        }).filter((doc) => doc !== null));
+    const currentDocumentsBatch = (
+      await Promise.all(
+          thisBatch.docs.map(async (doc) => {
+            const docPath = doc.ref.path;
+            const pathParams = utils.pathMatchesSelector(docPath, config.firestoreCollectionPath);
+
+            if (!isGroupQuery || (isGroupQuery && pathParams !== null)) {
+              return await utils.typesenseDocumentFromSnapshot(doc, pathParams);
+            } else {
+              return null;
+            }
+          }),
+      )
+    ).filter((doc) => doc !== null);
 
     lastDoc = thisBatch.docs.at(-1) ?? null;
     try {