Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for http_auth_domain spider attribute #67

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

nkls-so
Copy link
Contributor

@nkls-so nkls-so commented Aug 18, 2024

See https://doc.scrapy.org/en/latest/topics/downloader-middleware.html#module-scrapy.downloadermiddlewares.httpauth

Change Summary

Add the option to define the domain which requires the http authentication.

In previous Scrapy versions HttpAuthMiddleware sent the authentication data with all requests, which is a security problem if the spider makes requests to several different domains. Currently if the http_auth_domain attribute is not set, the middleware will use the domain of the first request, which will work for some spiders but not for others. In the future the middleware will produce an error instead.

@jasonbosco
Copy link
Member

Thanks @nkls-so!

@jasonbosco jasonbosco merged commit 1ac7843 into typesense:master Aug 26, 2024
1 check passed
@jasonbosco
Copy link
Member

This is now available in v0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants