Merge pull request #129 from uPortal-Project/fix_null_ACE

fix: NPE for ACEs check on samba share without NT rights
uPortal-Project · Apr 19, 2023 · 0bb6ebc · 0bb6ebc
2 parents bf1a52a + 9e31d20
commit 0bb6ebc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/main/java/org/esupportail/portlet/filemanager/services/cifs/CifsAccessImpl.java b/src/main/java/org/esupportail/portlet/filemanager/services/cifs/CifsAccessImpl.java
@@ -258,11 +258,13 @@ private JsTreeFile resourceAsJsTreeFile(SmbFile resource, SharedUserPortletParam
         if (!resourceWritable) {
             try {
                 ACE[] ACEs = resource.getSecurity();
-                for(ACE ace: ACEs) {
-                    if (this.userAuthenticator.getUsername().equals(ace.getSID().getAccountName())) {
-                        if ((ace.getAccessMask() & ACE.FILE_WRITE_DATA)!=0) {
-                            resourceWritable = true;
-                            break;
+                if (ACEs != null) {
+                    for (ACE ace : ACEs) {
+                        if (this.userAuthenticator.getUsername().equals(ace.getSID().getAccountName())) {
+                            if ((ace.getAccessMask() & ACE.FILE_WRITE_DATA) != 0) {
+                                resourceWritable = true;
+                                break;
+                            }
                         }
                     }
                 }