Hero branch to main (again) #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved changes to new branch "polygon_export" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises some of the functions in hero branch (charlie-dev) developed by @charparr ; some errors were missed by me @Joshdpaul in the first PR and are addressed here. I also simplified the function that exports the filtered ARs to a geodataframe. The notebook now compares number of ARs detected using different number of criteria, and does some simple investigation of the geodataframe result.
The basic PR steps have not changed, but note that the config.py, download.py, and compute_ivt.py scripts are unchanged. Therefore, if you have already downloaded and processed the data using the original charlie-dev branch, you can skip running those scripts and head right for the notebook.
Steps:
• set your env var export AR_DATA_DIR=...
• create your conda env from the environment.yml and activate it
• inspect the config.py file
• python download.py
• python compute_ivt.py
• use the AR_detection notebook to find some ARs!