Change cursor to "not allowed" when hovering over nonclickable area #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucecrevensten
approved these changes
May 12, 2023
| @@ -11,7 +11,7 @@ Data for this project was provided in CSV format. This repo includes a preproces | |||
| - Omit blank and infinite values | |||
| - Optimize data by removing unused fields and rounding to sensible digits | |||
|
|
|||
| To generate the needed JSON files, download the five CSV data files from [Google Drive](https://drive.google.com/drive/folders/1hrGuRmQtx-gTepN_H9BEfcGmnl5MCeAK?usp=sharing) and store them in `scripts/input`. Then run the following commands to convert them to JSON: | |||
| To generate the needed JSON files, download the five CSV data files from [Google Drive](https://drive.google.com/drive/folders/1hBjKEYzRPY7qQlbnqyMaYRMZSuMtIABB?usp=sharing) and store them in `scripts/input`. Then run the following commands to convert them to JSON: | |||
There was a problem hiding this comment.
Not for this PR, but we probably will want to pull this reference out to a stand-along (non-Google) location after we launch to decouple changes.
|
|
||
| # Get the boundary (perimeter) of entire set of AOIs. | ||
| gdf = gpd.GeoDataFrame( | ||
| gpd.GeoSeries(unary_union(gdf.geometry.values)), columns=["geometry"] |
There was a problem hiding this comment.
This is great, and, I think we should merge this now but we need to update it after the polygon simplification is done (#73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
This PR changes the mouse cursor to the "not allowed" cursor when it hovers outside of the clickable area.
To implement this, I also needed to generate a GeoJSON polygon of the selectable AOI perimeter to load into Leaflet so it would know what area was clickable. I've added the GeoJSON generating script to
scripts/boundary.pyand added instructions about how to run it to the main repo README, along with some documentation about how the shadow mask was generated since that had not yet been documented either, but is very related.To test, load the app, verify that you see the "nope" sign when you hover outside of the clickable area, and make sure the app still works like before in other respects.