Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary request made when runtime context is entered. #55

Draft
wants to merge 10 commits into
base: v1.x.y
Choose a base branch
from

Conversation

aaronweeden
Copy link

Description

This PR removes the unnecessary request that is made when the runtime context of the DataWarehouse is entered. The purpose of having it was to assert that a connection could be made to the XDMoD REST API; however, this will almost always occur just before another request is made, so there is no need to test the initial request.

Type of change:

  • Refactoring / documentation update (non-breaking change which does not change functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release preparation

Checklist:

  • CHANGELOG.md has been updated
  • xdmod_data/__version__.py has been updated to the next development version
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request
  • Updates have been made to the xdmod-notebooks repository as necessary, and the notebooks all run successfully
  • The changes in this PR have been ported/backported to other branches as needed

@aaronweeden aaronweeden added the refactor Refactor of existing functionality label Jan 28, 2025
@aaronweeden aaronweeden added this to the 1.1.0 milestone Jan 28, 2025
@aaronweeden aaronweeden force-pushed the remove-assert-connection branch from 3c6f6cb to a245a31 Compare January 28, 2025 21:50
@aaronweeden aaronweeden force-pushed the remove-assert-connection branch from dacba7b to 30313f5 Compare January 29, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant