-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate new permit data schema #222
Comments
No need. Drop support of old permits because people generally claim them immediately. If for some reason there's unclaimed old permits, we can provide the cloudflare deploy preview link of the previous commit. These all exist right now and no extra work is required. No need to make your job harder than it needs to be. |
@0x4007 Ok it makes sense. I tried to avoid any downtime or backfire during the update. Still this issue is relevant because the types and decode used should be updated to handle the new data shape of the permits! |
! action has an uncaught error |
/start |
Tips:
|
! action has an uncaught error |
@0x4007 regen here |
+ Evaluating results. Please wait... |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 5.7 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
> Ideally, we should avoid breaking all the old permits by handl... | 5.7 | 0.38 | 5.7 |
[ 208.4 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 25.4 |
Issue | Task | 1 | 150 |
Issue | Comment | 1 | 7.8 |
Issue | Comment | 1 | 0 |
Review | Comment | 1 | 16.8 |
Review | Comment | 1 | 8.4 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Multiple breaking changes have been introduced by the new struct... | 25.4a: count: 2 score: "2" words: 3 li: count: 2 score: "2" words: 18 code: count: 2 score: "2" words: 8 | 1 | 25.4 |
@0x4007 Ok it makes sense. I tried to avoid any downtime or back... | 7.8 | 0.9 | 7.8 |
@0x4007 Ok it makes sense. I tried to avoid any downtime or back... | - | 0.9 | - |
What's new: - the types got updated to use our new schema conta... | 16.8li: count: 3 score: "6" words: 35 code: count: 2 score: "4" words: 6 | 0.845 | 16.8 |
What's new: - the types got updated to use our new schema conta... | 8.4li: count: 3 score: "3" words: 35 code: count: 2 score: "2" words: 6 | 0.845 | 8.4 |
[ 0.3 WXDAI ]
@molecula451
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@0x4007 regen here... | 0.3 | 0.51 | 0.3 |
Multiple breaking changes have been introduced by the new structure of Permits located here
Consequently the
pay.ubq.fi
parser cannot properly populate the permit values, that use an old schema.Ideally, we should avoid breaking all the old permits by handling the two schema shapes in the first place, then eventually discard the old schema as every new permit will be generated with the new one.
Tasks to be carried out:
"@ubiquibot/permit-generation"
decode functionRelated conversation: ubiquity-os/permit-generation#10 (comment)
The text was updated successfully, but these errors were encountered: