Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate new permit data schema #222

Closed
gentlementlegen opened this issue Apr 12, 2024 · 9 comments · Fixed by #224
Closed

Accommodate new permit data schema #222

gentlementlegen opened this issue Apr 12, 2024 · 9 comments · Fixed by #224

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Apr 12, 2024

Multiple breaking changes have been introduced by the new structure of Permits located here

Consequently the pay.ubq.fi parser cannot properly populate the permit values, that use an old schema.

Ideally, we should avoid breaking all the old permits by handling the two schema shapes in the first place, then eventually discard the old schema as every new permit will be generated with the new one.

Tasks to be carried out:

  • include "@ubiquibot/permit-generation" decode function
  • handle both permit shapes and decode them properly

Related conversation: ubiquity-os/permit-generation#10 (comment)

@0x4007
Copy link
Member

0x4007 commented Apr 13, 2024

Ideally, we should avoid breaking all the old permits by handling the two schema shapes in the first place

No need. Drop support of old permits because people generally claim them immediately. If for some reason there's unclaimed old permits, we can provide the cloudflare deploy preview link of the previous commit. These all exist right now and no extra work is required.

No need to make your job harder than it needs to be.

@gentlementlegen
Copy link
Member Author

@0x4007 Ok it makes sense. I tried to avoid any downtime or backfire during the update. Still this issue is relevant because the types and decode used should be updated to handle the new data shape of the permits!

Copy link

ubiquibot bot commented Apr 15, 2024

! action has an uncaught error

@gentlementlegen
Copy link
Member Author

/start

Copy link

ubiquibot bot commented Apr 15, 2024

DeadlineMon, Apr 15, 3:27 PM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Apr 20, 2024

! action has an uncaught error

@molecula451
Copy link

@0x4007 regen here

@0x4007 0x4007 reopened this Apr 23, 2024
@0x4007 0x4007 closed this as completed Apr 23, 2024
Copy link

ubiquibot bot commented Apr 23, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Apr 23, 2024

[ 5.7 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment15.7
Conversation Incentives
CommentFormattingRelevanceReward
> Ideally, we should avoid breaking all the old permits by handl...
5.70.385.7

[ 208.4 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification125.4
IssueTask1150
IssueComment17.8
IssueComment10
ReviewComment116.8
ReviewComment18.4
Conversation Incentives
CommentFormattingRelevanceReward
Multiple breaking changes have been introduced by the new struct...
25.4
a:
  count: 2
  score: "2"
  words: 3
li:
  count: 2
  score: "2"
  words: 18
code:
  count: 2
  score: "2"
  words: 8
125.4
@0x4007 Ok it makes sense. I tried to avoid any downtime or back...
7.80.97.8
@0x4007 Ok it makes sense. I tried to avoid any downtime or back...
-0.9-
What's new: - the types got updated to use our new schema conta...
16.8
li:
  count: 3
  score: "6"
  words: 35
code:
  count: 2
  score: "4"
  words: 6
0.84516.8
What's new: - the types got updated to use our new schema conta...
8.4
li:
  count: 3
  score: "3"
  words: 35
code:
  count: 2
  score: "2"
  words: 6
0.8458.4

[ 0.3 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueComment10.3
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 regen here...
0.30.510.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants