Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update permit schema #224

Merged
merged 4 commits into from
Apr 20, 2024
Merged

feat!: update permit schema #224

merged 4 commits into from
Apr 20, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #222

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Apr 17, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Preview Deployment
5b8b4c70ad6561d59559aa29c547553f7c75874a
6d5595f9c4a4ba8936b28d35ea1087666fae7e31
efff1d7fce150a86358f0f1b026266330d8cad75

@gentlementlegen gentlementlegen requested a review from rndquu April 17, 2024 03:43
@gentlementlegen gentlementlegen marked this pull request as ready for review April 17, 2024 03:44
@gentlementlegen
Copy link
Member Author

What's new:

  • the types got updated to use our new schema contained within @ubiquibot/permit-generation
  • the code logic remains the same
  • the decode has also been updated to use @ubiquibot/permit-generation

@gentlementlegen gentlementlegen mentioned this pull request Apr 18, 2024
Merged
whilefoo
whilefoo requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

@0x4007 0x4007 mentioned this pull request Apr 19, 2024
Closed
@molecula451 molecula451 merged commit efff1d7 into ubiquity:development Apr 20, 2024
3 checks passed
@gentlementlegen gentlementlegen deleted the feat/update-permit-schema branch April 20, 2024 20:57
@ubiquibot ubiquibot bot mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molecula451 molecula451 molecula451 approved these changes

@whilefoo whilefoo whilefoo approved these changes

@rndquu rndquu Awaiting requested review from rndquu

@pavlovcik pavlovcik Awaiting requested review from pavlovcik

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accommodate new permit data schema
4 participants
@gentlementlegen @0x4007 @molecula451 @whilefoo