-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Population of Permits #368
Comments
there is no upper bound to graphql query return count, its up to us to set that limit actually |
The order got changed after you request: There is a graphql limit to a 100 nodes, will crash beyond that (you need pagination). Also, sending more that a 100 nodes in a query also crashes the request. |
/start |
! You must be a core team member, or an administrator to start this task |
Important
|
Passed the disqualification threshold and no activity is detected, removing assignees: @pbkompasz. |
/start |
! You must be a core team member, or an administrator to start this task |
@zugdev I am already working on this and planned to open a PR today. |
You passed the threshold therefore I tried to start, it is generally a good idea to open a PR as soon as you start the issue. If you really do open the PR today, you can proceed, no worries! |
@zugdev I'll open a draft PR shortly.
When I applied initially the bot rejected the application and I only saw that I was manually assigned yesterday, but I am working on it. |
The rejection is because this task is reserved to admins and collaborators which is why it closed the pull-request and did not assign you. |
I have a few points based on building the
|
Doesn't matter much in this context. If its invalid due to the funder revoking it, or if it was already claimed- theres no point to display it on the claims UI because its unclaimable anyways.
I would take the one of highest value! |
I'd also suggest some kind of cache like a timestamp of the most recent permit generated at that point when searched so that upon return the next search begins from there vs trawling through all previous permits issues again. A cache of unclaimed permits could exist where items are popped once they are claimed, to ensure historical permits prior to the search timestamp are not "forgotten". |
So now we should be able to go directly to pay.ubq.fi and it should automatically populate the permits.
If we pass in the permit directly (as we do normally) then it should just load the permit as it currently does.
The automatic population should add the permits to the queue after and only if logged in.
I reviewed the updated metadata and we should search for
The text was updated successfully, but these errors were encountered: