feat: Populate permits from metadata #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
! You must be a core team member, or an administrator to start this task |
Unused exports (1)
|
|
|
@zugdev The PR got closed, can I reopen it or do I have to be assigned to the task? |
0x4007
reviewed
Feb 4, 2025
| } | ||
|
|
||
| // Using our metadata system we can easily GraphQL query for permits. | ||
| const permits = (await supabase.from("permits").select("*").eq("beneficiary_id", githubId)).data; |
There was a problem hiding this comment.
Looks very wrong. Permits should load from GitHub not supabase
Comment on lines
+44
to
+48
| // TODO | ||
| owner: "0x70997970C51812dc3A010C7d01b50e0d17dc79C8", | ||
| // TODO | ||
| tokenAddres: "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d", | ||
| tokenType: "ERC20" |
There was a problem hiding this comment.
Doesn't make sense should be read from permits
Comment on lines
+52
to
+54
| // limit to previous 100 results or whatever is the max that GraphQL can return in a single shot | ||
| // check if they have already been claimed, if so, discard | ||
| // if unclaimed permits are found, import into the UI (we should already support multiple permits to be loaded in the UI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #368